Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move LTS README link to increase prominence #14259

Closed
wants to merge 1 commit into from
Closed

doc: move LTS README link to increase prominence #14259

wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Jul 16, 2017

The LTS Readme contains info that is relevant to current releases as well.

Fixes: #10718

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 16, 2017
@Trott
Copy link
Member

Trott commented Jul 16, 2017

Doesn't that placement suggest that the LTS README will have information on NIghtly builds too? It doesn't. Is that a problem?

@mscdex mscdex added lts Issues and PRs related to Long Term Support releases. and removed lts Issues and PRs related to Long Term Support releases. labels Jul 16, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Jul 16, 2017

LTS is becoming the Release WG (see nodejs/Release#223), and will thus have more general info about releases, which means that it should probably cover nightlies as well (assuming we don't move that info into this repo).

@gibfahn gibfahn mentioned this pull request Jul 17, 2017
Closed
jasnell pushed a commit that referenced this pull request Jul 17, 2017
@gibfahn @jasnell
doc: move LTS README link to increase prominence
7ae23fe 
PR-URL: #14259
Fixes: #10718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jul 17, 2017

Landed in 7ae23fe

@jasnell jasnell closed this Jul 17, 2017
@gibfahn gibfahn deleted the link-lts branch July 18, 2017 02:47
@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@gibfahn @addaleax
doc: move LTS README link to increase prominence
6f13d7d 
PR-URL: #14259
Fixes: #10718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@gibfahn @Fishrock123
doc: move LTS README link to increase prominence
abd901d 
PR-URL: #14259
Fixes: #10718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@gibfahn @MylesBorins
doc: move LTS README link to increase prominence
f766d35 
PR-URL: #14259
Fixes: #10718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@gibfahn @MylesBorins
doc: move LTS README link to increase prominence
41e4e46 
PR-URL: #14259
Fixes: #10718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@gibfahn @MylesBorins
doc: move LTS README link to increase prominence
8b69504 
PR-URL: #14259
Fixes: #10718
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the Current branch considered?
8 participants
@gibfahn @Trott @jasnell @refack @TimothyGu @mscdex @MylesBorins @nodejs-github-bot